fix: Update readme to make code example run #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohh, make sense tbh |
shuhuiluo
requested changes
Jul 25, 2024
README.md
Outdated
Comment on lines
62
to
63
| const ANOTHER_TOKEN_ADDRESS: &str = "0x0000000000000000000000000000000000000002"; | ||
| let another_token = token!(CHAIN_ID, ANOTHER_TOKEN_ADDRESS, DECIMALS, "ETH", "Ethereum"); |
There was a problem hiding this comment.
Suggested change
| const ANOTHER_TOKEN_ADDRESS: &str = "0x0000000000000000000000000000000000000002"; | |
| let another_token = token!(CHAIN_ID, ANOTHER_TOKEN_ADDRESS, DECIMALS, "ETH", "Ethereum"); | |
| let another_token = token!( | |
| CHAIN_ID, | |
| "0000000000000000000000000000000000000002", | |
| DECIMALS, | |
| "ETH", | |
| "Ethereum" | |
| ); |
token! can take either string literal or &str. If passing string literal to address! macro, "0x" should be stripped.
README.md
Outdated
Comment on lines
39
to
40
| use uniswap_sdk_core::prelude::*; | ||
| use uniswap_sdk_core::token; |
There was a problem hiding this comment.
Suggested change
| use uniswap_sdk_core::prelude::*; | |
| use uniswap_sdk_core::token; | |
| use crate::{prelude::*, token}; |
shuhuiluo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, had to to make a couple updates to the code example in the readme to get it to run on my machine. Might have been something I did wrong, but this runs out of the box for me. Sharing in case it's useful.